fix: replace curl with wget in pgadmin healthcheck#23
Conversation
The dpage/pgadmin4 image does not ship with curl, causing the healthcheck to fail with "executable file not found" and the container to be marked unhealthy (breaking Traefik discovery). Switched to wget --no-verbose --tries=1 --spider, consistent with other services in the project (traefik, mailpit). Also switched pgadmin middleware from strict-headers to relaxed-headers to match its routing requirements. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary of ChangesHello @fkrzski, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses critical operational issues with the 'pgadmin' service within the Docker Compose setup. It resolves the 'pgadmin' container's healthcheck failures, which were caused by the absence of 'curl' in its base image, by switching to 'wget'. Additionally, it adjusts the Traefik middleware configuration for 'pgadmin' to ensure proper routing and compatibility. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly fixes the pgadmin healthcheck by replacing curl with wget, as curl is not available in the dpage/pgadmin4 image. The change to use relaxed-headers for pgadmin is also noted. I have two suggestions: one to improve the robustness of the new healthcheck configuration, and another to highlight a security consideration regarding the change in headers.
1 participant
The dpage/pgadmin4 image does not ship with curl, causing the healthcheck to fail with "executable file not found" and the container to be marked unhealthy (breaking Traefik discovery).
Switched to wget --no-verbose --tries=1 --spider, consistent with other services in the project (traefik, mailpit).
Also switched pgadmin middleware from strict-headers to relaxed-headers to match its routing requirements.